Nguyễn Thái Ngọc Duy <pclo...@gmail.com> writes: > Changes since v1: > > - fopen_or_warn() and warn_on_fopen_errors() are introduced. The > latter's name is probably not great... > - A new patch (first one) to convert a bunch to using xfopen() > - Fix test failure on Windows, found by Johannes Sixt > - Fix the memory leak in log.c, found by Jeff > > There are still a couple of fopen() remained, but I'm getting slow > again so let's get these in first and worry about the rest when > somebody has time. > > Nguyễn Thái Ngọc Duy (21): > Use xfopen() in more places > clone: use xfopen() instead of fopen() > config.mak.uname: set FREAD_READS_DIRECTORIES for Linux and FreeBSD > wrapper.c: add warn_on_fopen_errors() > wrapper.c: add fopen_or_warn() > attr.c: use fopen_or_warn() > ident.c: use fopen_or_warn() > bisect: report on fopen() error > blame: report error on open if graft_file is a directory > log: report errno on failure to fopen() a file > log: fix memory leak in open_next_file() > commit.c: report error on failure to fopen() the graft file > remote.c: report error on failure to fopen() > rerere.c: report error on failure to fopen() > rerere.c: report correct errno > sequencer.c: report error on failure to fopen() > server-info: report error on failure to fopen() > wt-status.c: report error on failure to fopen() > xdiff-interface.c: report errno on failure to stat() or fopen() > config.c: handle error on failing to fopen() > t1308: add a test case on open a config directory
Thanks. If the number of parts affected by this series were smaller, it may have made the review easier to have the introduction of a helper and its use in a single larger patch, but there are spread across many, some with files that are touched by different in-flight topics, and these "collection of smaller patches" makes it easier to manage both while reviewing and also merging. All looked good, even though I do share the doubt on the name "warn-on-fopen-errors"; when something applies equally to fopen(3) and underlying open(2), I would tend to call that with open not fopen myself. But that is a minor point.
