On Thu, May 11, 2017 at 1:30 AM, Jonathan Nieder <[email protected]> wrote: > Hi, > > Ęvar Arnfjörš Bjarmason wrote: > > [...] >> # call at least one of these to establish an appropriately-sized repository >> +test_perf_fresh_repo () { >> + repo="${1:-$TRASH_DIRECTORY}" >> + "$MODERN_GIT" init -q "$repo" && >> + cd "$repo" && >> + test_perf_do_repo_symlink_config_ >> +} > > Unlike the other two variants, wouldn't this leave the cwd inside the > new repo? > > In other words, I wonder if the commands starting with the 'cd' should > be in a subshell. > > Thanks and hope that helps,
Yup, I'll fix that. Thanks for the review & also on the other patch. Will send a v3 with these issues fixed.
