Ævar Arnfjörð Bjarmason <[email protected]> writes: > On Thu, May 11, 2017 at 9:46 AM, Junio C Hamano <[email protected]> wrote: >> I was hoping that by ejecting a few topics out of 'pu', we could >> finally see all the build jobs pass their tests under Travis CI. >> Unfortunately, no such luck. It seems that we have some new issues >> with Gettext-Poison build/test after updates to t0027. Also the >> updated compatibility regexp thing taken from gawk is not liked by >> the Windows compiler. >> >> Not all of these may not be new issues, but nevertheless, it would >> be nice if we can see all build jobs succeed every once in a while, >> not just for the three stable integration branches but also for 'pu' >> ;-) > > The gettext part is my bad, I never tested with EXPENSIVE which > Torsten removed, so now the test runs & fails under poison. > > This trivial fixup makes it pass: > > diff --git a/t/t0027-auto-crlf.sh b/t/t0027-auto-crlf.sh > index effc3db0d5..deb3ae7813 100755 > --- a/t/t0027-auto-crlf.sh > +++ b/t/t0027-auto-crlf.sh > @@ -69,7 +69,7 @@ check_warning () { > *) echo >&2 "Illegal 1": "$1" ; return false ;; > esac > grep "will be replaced by" "$2" | sed -e "s/\(.*\) in [^ > ]*$/\1/" | uniq >"$2".actual > - test_cmp "$2".expect "$2".actual > + test_i18ncmp "$2".expect "$2".actual > } > > commit_check_warn () { > > Can you please squash that into my patch?
Sure. Thanks for a quick response.
