On Thu, Nov 15, 2012 at 4:32 AM, Nguyễn Thái Ngọc Duy <pclo...@gmail.com> wrote:
> There are two implementations of append_signoff in log-tree.c and
> sequencer.c, which do more or less the same thing. This patch
>  - teaches sequencer.c's append_signoff() not to append the signoff if
>    it's already there but not at the bottom
>  - removes log-tree.c's
>  - make sure "Signed-off-by: foo" in the middle of a line is not
>    counted as a sign off
> Signed-off-by: Nguyễn Thái Ngọc Duy <pclo...@gmail.com>
> ---
>  Interestingly this patch triggers the fault that it fixes.
>  I was surprised that there was no blank line before my S-o-b
>  and thought I broke something. It turns out I used unmodified
>  format-patch and it mistook the S-o-b quote as true S-o-b line.
>  The modified one puts the blank line back.

Heh, yeah I noticed this bug yesterday when I submitted my changes
affecting the same area of code (sequence.c).  Glad I didn't waste too
much time fixing it.

Have you looked at this:


That series doesn't duplicate your work, but the two series's should
be resolved.

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to