On Sun, May 21, 2017 at 11:25:39PM +0100, Ramsay Jones wrote:
> Commit d8193743e0 ("usage.c: add BUG() function", 12-05-2017) added the
> BUG() functions and macros as a replacement for calls to die("BUG: ..").
> The use of NORETURN on the declarations (in git-compat-util.h) and the
> lack of NORETURN on the function definitions, however, leads sparse to
> complain thus:
>
> SP usage.c
> usage.c:220:6: error: symbol 'BUG_fl' redeclared with different type
> (originally declared at git-compat-util.h:1074) - different modifiers
>
> In order to suppress the sparse error, add the NORETURN to the function
> definitions.
>
> Signed-off-by: Ramsay Jones <ram...@ramsayjones.plus.com>
Thanks, I never ended up re-rolling the original, but from our previous
discussion this is obviously fine by me.
-Peff
