On Tue, May 30, 2017 at 03:08:25PM +0900, Junio C Hamano wrote: > Jeff King <p...@peff.net> writes: > > > On Tue, May 30, 2017 at 03:03:18PM +0900, Junio C Hamano wrote: > > > >> > +test_expect_success 'generate builtin list' ' > >> > + git --list-builtins >builtins > >> > +' > >> > + > >> > +while read builtin > >> > +do > >> > + test_expect_success "$builtin can handle -h" ' > >> > + test_expect_code 129 git $builtin -h >output 2>&1 && > >> > + test_i18ngrep usage output > >> > + ' > >> > +done <builtins > >> > + > >> > >> These still seem to need further tweaks? > >> > >> diff-files > >> diff-index > >> diff-tree > >> rev-list > > > > How so? They pass the test for me, and the output for a manual run looks > > sane. > > Am I missing some patches (I have these 8) outside the series, > perhaps?
Nope, I have those patches directly on your e83352ef23, and it passes. I wonder if there's something funny between our environments. What does the failure look like for you? -Peff
