Jiang Xin <[email protected]> writes: > 2017-05-12 5:20 GMT+08:00 Ævar Arnfjörð Bjarmason <[email protected]>: >> Change all the "TRANSLATORS: [...]" comments in the C code to use the >> regular Git coding style, and amend the style guide so that the >> example there uses that style. >> >> This custom style was necessary back in 2010 when the gettext support >> was initially added, and was subsequently documented in commit >> cbcfd4e3ea ("i18n: mention "TRANSLATORS:" marker in >> Documentation/CodingGuidelines", 2014-04-18). >> >> GNU xgettext hasn't had the parsing limitation that necessitated this >> exception for almost 3 years. Since its 0.19 release on 2014-06-02 >> it's been able to recognize TRANSLATOR comments in the standard Git >> comment syntax[1]. > > My gettext version is 0.19.8.1. I applied this patch and checked the > new generated `git.pot` file, all "TRANSLATORS:" directions are well > kept as usual.
Ævar, sorry that this patch fell through cracks about 20 days ago. I'll queue with Acked-by by Jiang. Thanks, both.
