On Mon, Nov 19, 2012 at 8:27 PM, Junio C Hamano <[email protected]> wrote: > Krzysztof Mazur <[email protected]> writes: > >> On Mon, Nov 19, 2012 at 11:57:47AM +0200, Felipe Balbi wrote: >>> Hi guys, >>> >>> for whatever reason my git has started acting up with >>> [email protected] addresses. It doesn't manage to extract a valid >>> adress from the string: >>> >>> Cc: <[email protected]> # v3.4 v3.5 v3.6 >>> >>> Removing the comment at the end of the line makes things work again. I >>> do remember, however, seeing this working since few weeks back I sent a >>> mail to stable (in fact the same one I'm using to test), so this could >>> be related to some perl updates, who knows ?!? >> >> You probably just installed Email::Valid package. >> >> The current git-send-email works a little better and just prints an error: >> >> W: unable to extract a valid address from: <[email protected]> #v3.4 >> v3.5 v3.6 >> >> >> This patch should fix the problem, now after <email> any garbage is >> removed while extracting address. >> >> diff --git a/git-send-email.perl b/git-send-email.perl >> index 5a7c29d..bb659da 100755 >> --- a/git-send-email.perl >> +++ b/git-send-email.perl >> @@ -828,7 +828,7 @@ sub extract_valid_address { >> # check for a local address: >> return $address if ($address =~ /^($local_part_regexp)$/); >> >> - $address =~ s/^\s*<(.*)>\s*$/$1/; >> + $address =~ s/^\s*<(.*)>.*$/$1/; >> if ($have_email_valid) { >> return scalar Email::Valid->address($address); >> } else { > > Given that the problematic line > > Stable Kernel Maintainance Track <[email protected]> # vX.Y > > is not even a valid e-mail address, doesn't this new logic belong to > sanitize_address() conceptually?
That would be great, it would also help the cc-cmd stuff. The get_maintainer.pl patch from the Linux kernel outputs something like: David Airlie <[email protected]> (maintainer:DRM DRIVERS) Ben Skeggs <[email protected]> (commit_signer:17/19=89%,commit_signer:43/46=93%) Maxim Levitsky <[email protected]> (commit_signer:3/19=16%) Greg Kroah-Hartman <[email protected]> (commit_signer:2/19=11%) Dave Airlie <[email protected]> (commit_signer:2/19=11%,commit_signer:3/46=7%) Alex Deucher <[email protected]> (commit_signer:1/19=5%) [email protected] (open list:DRM DRIVERS) [email protected] (open list) -- Felipe Contreras -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html
