On Mon, Jun 12, 2017 at 10:06:13AM +0200, Michael Haggerty wrote: > So instead: > > * Extract a function `validate_packed_ref_cache()` that does the > validity check independent of whether the lock is held. > > * Change `get_packed_ref_cache()` to call the new function, but only > if the lock *isn't* held. > > * Change `lock_packed_refs()` to call the new function in any case > before calling `get_packed_ref_cache()`. > > * Fix the comment in `lock_packed_refs()`.
Your explanation makes perfect sense, and I agree this should fix the problem. Sorry to have missed it in review. -Peff
