This goes on top of sb/hashmap-customize-comparison.
No functional impact but a pure cleanup series:
No casts to hashmap_cmp_fn in the whole code base any more.
This revealed another interesting thing, which is not a bug per se:
The const correctness of hashmap_cmp_fn as it requires all its void
pointers to be const!
We violate this in patch-ids.c as we modify the `fndata` at some
uncritical part (a part that doesn't change the equal-functionality
AFAICT).
Thanks,
Stefan
Stefan Beller (10):
attr.c: drop hashmap_cmp_fn cast
builtin/difftool.c: drop hashmap_cmp_fn cast
builtin/describe: drop hashmap_cmp_fn cast
config.c: drop hashmap_cmp_fn cast
convert/sub-process: drop cast to hashmap_cmp_fn
patch-ids.c: drop hashmap_cmp_fn cast
remote.c: drop hashmap_cmp_fn cast
submodule-config.c: drop hashmap_cmp_fn cast
name-hash.c: drop hashmap_cmp_fn cast
t/helper/test-hashmap: use custom data instead of duplicate cmp
functions
attr.c | 12 +++++++-----
builtin/describe.c | 9 ++++++---
builtin/difftool.c | 37 ++++++++++++++++++++++---------------
config.c | 10 ++++++----
convert.c | 3 +--
name-hash.c | 22 +++++++++++++---------
patch-ids.c | 14 +++++++++-----
remote.c | 12 ++++++++----
sub-process.c | 7 +++++--
sub-process.h | 4 ++--
submodule-config.c | 18 ++++++++++++------
t/helper/test-hashmap.c | 34 ++++++++++++++++------------------
12 files changed, 107 insertions(+), 75 deletions(-)
--
2.13.0.31.g9b732c453e
