Ævar Arnfjörð Bjarmason <[email protected]> writes: >>> diff --git a/.gitmodules b/.gitmodules >>> new file mode 100644 >>> index 0000000000..cbeebdab7a >>> --- /dev/null >>> +++ b/.gitmodules >>> @@ -0,0 +1,4 @@ >>> +[submodule "sha1collisiondetection"] >>> + path = sha1collisiondetection >>> + url = https://github.com/cr-marcstevens/sha1collisiondetection.git >>> + branch = master >> >> Do we need to say this "branch" bit? > > Yes, it's to make future updates easier, see b928922727 ("submodule add: > If --branch is given, record it in .gitmodules", 2012-12-19).
Why? It's not like we want to _follow_ the 'master' branch of that sha1collisiondetection repository. We declare that a specific commit from the (sub)module is suited for our project, and do not really care to automatically update from whatever happens to be at the tip of 'master' there. > >> Other than that looks good to me. >> >> Thanks.
