On 07/11, Jacob Keller wrote: > On Tue, Jul 11, 2017 at 3:04 PM, Brandon Williams <bmw...@google.com> wrote: > > Convert grep to use 'struct repository' which enables recursing into > > submodules to be handled in-process. > > > > Signed-off-by: Brandon Williams <bmw...@google.com> > > --- > > Documentation/git-grep.txt | 7 - > > builtin/grep.c | 390 > > +++++++++------------------------------------ > > cache.h | 1 - > > git.c | 2 +- > > grep.c | 13 -- > > grep.h | 1 - > > setup.c | 12 +- > > 7 files changed, 81 insertions(+), 345 deletions(-) > > > > No real indepth comments here, but it's nice to see how much code > reduction this has enabled!
Yeah overall, with this and the ls-files conversion, I'm really pleased with how much cleaner the code looks moving to working in-process. -- Brandon Williams
