On Sun, Aug 06, 2017 at 11:38:50PM +0000, Ævar Arnfjörð Bjarmason wrote: > Change an argument to test_line_count (which'll ultimately be turned > into a "test" expression) to use "-gt" instead of ">" for an > arithmetic test. > > This broken on e.g. OpenBSD as of v2.13.0 with my commit > ac3f5a3468 ("ref-filter: add --no-contains option to > tag/branch/for-each-ref", 2017-03-24). > > Upstream just worked around it by patching git and didn't tell us > about it, I discovered this when reading various Git packaging > implementations: https://github.com/openbsd/ports/commit/7e48bf88a20 > > Signed-off-by: Ævar Arnfjörð Bjarmason <ava...@gmail.com> > --- > > David, it would be great to get a quick bug report to > email@example.com if you end up having to monkeypatch something > we've done. We won't bite, promise :) > > As shown in that linked Github commit OpenBSD has another recent > workaround in turning on DIR_HAS_BSD_GROUP_SEMANTICS and skipping a > related test, maybe René can make more sense of that?
I've confirmed using the NetBSD 7.1 man pages that NetBSD will also want DIR_HAS_BSD_GROUP_SEMANTICS. MirBSD will also, according to its man pages. As I understand it, the only consequence of not setting this flag on BSD systems is that some directories will be setgid, which, while ugly and useless, should have no negative effect. -- brian m. carlson / brian with sandals: Houston, Texas, US https://www.crustytoothpaste.net/~bmc | My opinion only OpenPGP: https://keybase.io/bk2204
Description: PGP signature