René Scharfe <[email protected]> writes:
>> diff --git a/builtin/add.c b/builtin/add.c
>> index e888fb8c5..385b53ae7 100644
>> --- a/builtin/add.c
>> +++ b/builtin/add.c
>> @@ -43,7 +43,7 @@ static void chmod_pathspec(struct pathspec *pathspec, int
>> force_mode)
>> continue;
>>
>> if (chmod_cache_entry(ce, force_mode) < 0)
>> - fprintf(stderr, "cannot chmod '%s'", ce->name);
>> + fprintf(stderr, "cannot chmod '%s'\n", ce->name);
>> }
>> }
>
> FYI: I brought this up yesterday in the original thread, along with a
> few other observations:
>
> https://public-inbox.org/git/[email protected]/
>
> Not sure if the discussion can or should be revived after all this
> time, though; just sending patches like yours might be the way to go.
Thanks, so it should become
fprintf(stderr, "cannot chmod %c '%s'\n", force_mode, ce->name);
in the final version to be queued?