Ramkumar Ramachandra <artag...@gmail.com> writes:

> Change the tense of test names from past to present, as this is the
> prevalent style.
> Signed-off-by: Ramkumar Ramachandra <artag...@gmail.com>
> ---

I see most of them are not "past" but "past particle" used as if
they are adjectives.

For example, I think this test

> -test_expect_success 'added submodule' '

tries to say "See what happens to an added submodule".

The same for the others.

> -test_expect_success 'modified submodule(forward)' '

"See what is shown for modified submodule."

> -test_expect_success 'typechanged submodule(submodule->blob), --cached' '

"See what is shown for typechanged one, when --cached option is

So I do not think this patch is needed; the current wording looks
not so grammatically kosher, but still is understandable.  Updated
result isn't.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to