On Thu, Aug 17, 2017 at 10:27 AM, Junio C Hamano <[email protected]> wrote: > Long time ago, 23707811 ("diff: do not chomp hunk-header in the > middle of a character", 2008-01-02) introduced sane_truncate_line() > helper function to trim the "function header" line that is shown at > the end of the hunk header line, in order to avoid chomping it in > the middle of a single UTF-8 character. It also added a facility to > define a custom callback function to make it possible to extend it > to non UTF-8 encodings. > > During the following 8 1/2 years, nobody found need for this custom > callback facility. > > A custom callback function is a wrong design to use here anyway---if > your contents need support for non UTF-8 encoding, you shouldn't > have to write a custom function and recompile Git to plumb it in. A > better approach would be to extend sane_truncate_line() function and > have a new member in emit_callback to conditionally trigger it. > > Signed-off-by: Junio C Hamano <[email protected]>
This patch is Reviewed-by: Stefan Beller <[email protected]> However while strolling around in code nearby, I do wonder if sane_truncate_line needs to make use of the return value of utf8_width. But that is not the case as we're interested in the byte length, not the print length. Thanks Stefan
