On 27 August 2017 at 20:21, Lars Schneider <[email protected]> wrote: > >> On 27 Aug 2017, at 09:37, Martin Ågren <[email protected]> wrote: >> >> The static-ness was silently dropped in commit 70428d1a5 ("pkt-line: add >> packet_write_fmt_gently()", 2016-10-16). As a result, for each call to >> packet_write_fmt_1, we allocate and leak a buffer. > > Oh :-( Thanks for detecting and fixing the leak. > > How did you actually find it? Reading the code or did you use some > tool?
Valgrind found it for me. Most leaks it reports are "ok" since we're about to exit, it just takes more or less effort to realize that... Martin
