On Sun, Sep 17, 2017 at 10:42 PM, Christian Couder <[email protected]> wrote: > On Sun, Sep 17, 2017 at 10:17 PM, phionah bugosi <[email protected]> wrote: >> Signed-off-by: phionah bugosi <[email protected]> >> --- >> builtin/pack-objects.c | 5 +++-- >> cache.h | 7 ------- >> list.h | 6 ++++++ >> packfile.c | 12 ++++++------ >> 4 files changed, 15 insertions(+), 15 deletions(-) >> >> This patch makes packed_git_mru global a value instead of a pointer and >> makes use of list.h > > Please explain _why_ you are doing that (why is the resulting code better).
Also the explanations should be in the commit message, that is above your "Signed-off-by: ..." line.
