Documentation/CodingGuidelines says,
"Some clever tricks, like using the !! operator with arithmetic
constructs, can be extremely confusing to others. Avoid them,
unless there is a compelling reason to use them."
There was a usage for which there's no compelling reason.So, replace
such a usage as with something else that expresses the intent more
clearly.
Signed-off-by: Kaartic Sivaraam <[email protected]>
---
I think the expression,
!!opts.new_branch_force
is equivalent to,
opts.new_branch_force != NULL
in all cases. If it's not, let me know.
builtin/checkout.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
diff --git a/builtin/checkout.c b/builtin/checkout.c
index 5c202b7af..76859da9d 100644
--- a/builtin/checkout.c
+++ b/builtin/checkout.c
@@ -1281,11 +1281,10 @@ int cmd_checkout(int argc, const char **argv, const
char *prefix)
if (opts.new_branch) {
struct strbuf buf = STRBUF_INIT;
+ int force = opts.new_branch_force != NULL;
- opts.branch_exists =
- validate_new_branchname(opts.new_branch, &buf,
- !!opts.new_branch_force,
- !!opts.new_branch_force);
+ opts.branch_exists = validate_new_branchname(opts.new_branch,
&buf,
+ force, force);
strbuf_release(&buf);
}
--
2.14.1.868.g66c78774b
