> -----Original Message-----
> From: Junio C Hamano [mailto:[email protected]]
> Sent: Thursday, September 28, 2017 10:21 PM
> To: Ben Peart <[email protected]>
> Cc: [email protected]; [email protected];
> [email protected]; [email protected];
> [email protected]; [email protected]; [email protected]
> Subject: Re: [PATCH v8 00/12] Fast git status via a file system watcher
>
> Ben Peart <[email protected]> writes:
>
> > The only behavioral change from V7 is the removal of unnecessary uses
> > of CE_MATCH_IGNORE_FSMONITOR. With a better understanding of
> *why*
> > the
> > CE_MATCH_IGNORE_* flags are used, it is now clear they are not
> > required in most cases where CE_MATCH_IGNORE_FSMONITOR was being
> > passed out of an abundance of caution.
>
> The reviews and updates after this round was posted were to
>
> * 01/12 had an obvious pointer-vs-pointee thinko, which I think I
> have locally fixed;
>
> * 08/12 forgot to add a new test executable to .gitignore file,
> which I think I have locally fixed, too.
>
> Any other review comments and suggestions for improvements?
> Otherwise I am tempted to declare victory and merge this to 'next'
> soonish.
>
> For reference, here is the interdiff between what was posted as v8 and what
> I have on 'pu'.
I had accumulated the same set of changes with one addition of removing
a duplicate "the" from a comment in the fsmonitor.h file:
diff --git a/fsmonitor.h b/fsmonitor.h
index 8eb6163455..0de644e01a 100644
--- a/fsmonitor.h
+++ b/fsmonitor.h
@@ -4,7 +4,7 @@
extern struct trace_key trace_fsmonitor;
/*
- * Read the the fsmonitor index extension and (if configured) restore the
+ * Read the fsmonitor index extension and (if configured) restore the
* CE_FSMONITOR_VALID state.
*/
extern int read_fsmonitor_extension(struct index_state *istate, const void
*data, unsigned long sz);
>
> Thanks.
>
> compat/bswap.h | 4 ++--
> t/helper/.gitignore | 1 +
> 2 files changed, 3 insertions(+), 2 deletions(-)
>
> diff --git b/compat/bswap.h a/compat/bswap.h index
> 6b22c46214..5078ce5ecc 100644
> --- b/compat/bswap.h
> +++ a/compat/bswap.h
> @@ -183,8 +183,8 @@ static inline uint32_t get_be32(const void *ptr) static
> inline uint64_t get_be64(const void *ptr) {
> const unsigned char *p = ptr;
> - return (uint64_t)get_be32(p[0]) << 32 |
> - (uint64_t)get_be32(p[4]) << 0;
> + return (uint64_t)get_be32(&p[0]) << 32 |
> + (uint64_t)get_be32(&p[4]) << 0;
> }
>
> static inline void put_be32(void *ptr, uint32_t value) diff --git
> b/t/helper/.gitignore a/t/helper/.gitignore index f9328eebdd..87a648a7cf
> 100644
> --- b/t/helper/.gitignore
> +++ a/t/helper/.gitignore
> @@ -5,6 +5,7 @@
> /test-delta
> /test-drop-caches
> /test-dump-cache-tree
> +/test-dump-fsmonitor
> /test-dump-split-index
> /test-dump-untracked-cache
> /test-fake-ssh
