On Sun, Oct 08, 2017 at 11:37:14PM +0200, Lars Schneider wrote: > >> Yeah, I think that makes more sense. > >> > >> A patch may look like this on top of these two patches, but I'd > >> prefer to see Lars's eyeballing and possibly wrapping it up in an > >> applicable patch after taking the authorship. > > > > This looks all good to me. Thank you! > A few minor style suggestions below.
Thanks, these were all reasonable (I actually avoided unwrapping some of the lines in the original to make the "-w" diff more readable :) ). I ended up breaking this into three commits, since I think that makes it easier to see what each of the changes is doing. Here's what I have (on top of what Junio has already queued in ls/filter-process-delayed): [v2 1/3]: write_entry: fix leak when retrying delayed filter [v2 2/3]: write_entry: avoid reading blobs in CE_RETRY case [v2 3/3]: write_entry: untangle symlink and regular-file cases entry.c | 83 ++++++++++++++++++++++++++++++++++++++--------------------------- 1 file changed, 48 insertions(+), 35 deletions(-) -Peff
