Jeff Hostetler <[email protected]> writes: > From: Jeff Hostetler <[email protected]> > > Refactor add_excludes() to separate the reading of the > exclude file into a buffer and the parsing of the buffer > into exclude_list items. > > Add add_excludes_from_blob_to_list() to allow an exclude > file be specified with an OID without assuming a local > worktree or index exists. > > Refactor read_skip_worktree_file_from_index() and add > do_read_blob() to eliminate duplication of preliminary > processing of blob contents. > > Signed-off-by: Jeff Hostetler <[email protected]> > ---
Yeah, with a separate do_read_blob() helper, this one looks a lot easier to follow, at least to me---as the author, you might find the earlier one just as easy, I suspect, though ;-) Thanks. Will queue.
