Stefan Beller <[email protected]> writes:
> After some quick research our coding style on bit fields is twofold:
> Most older code is this way and more recent code seems to prefer
>
> unsigned <FLAGNAME> SP : SP ;
Yes, we are very inconsistent. What does the clang format rules
Brandon came up with have to say on this? FWIW, checkpatch.pl is
unhappy without spaces on both side.
>> +static inline void diff_flags_or(struct diff_flags *a,
>> + const struct diff_flags *b)
>> +{
>> + char *tmp_a = (char *)a;
>> + const char *tmp_b = (const char *)b;
>> + int i;
>> +
>> + for (i = 0; i < sizeof(struct diff_flags); i++)
>
> I think most of the code prefers to put the variable into the sizeof
> argument i.e. 'sizeof(*a)', as that is presumably more maintainable.
> (If the type of 'a' changes, then we don't forget to adapt this place,
> but the compiler can take care of it.
Yup, but in this case we won't change the type, no?
