On Mon, 6 Nov 2017 12:51:52 -0500 Jeff Hostetler <g...@jeffhostetler.com> wrote:
> Jonathan and I were talking off-list about the performance > effects of inspecting the pathnames to identify the ".git*" > special files. I added it in my first draft back in the spring, > thinking that even if you set the blob-limit to a small > number (or zero), you'd probably still always want the > .gitattribute and .gitignore files. But now with the addition > of the sparse filter and functional dynamic object fetching, > I'm not sure I see the need for this. > > Also, if the primary use of the blob-limit is to filter out > giant binary assets, it is unlikely anyone is going to have > a 1MB+ .git* file, so it is unlikely that the is_special_file > would include anything that wouldn't already be included by > the size criteria. > > So, if there's no objections, I think I'll remove this and > simplify the blob-limit filter function. (That would let me > get rid of the provisional omit code here.) This sounds like a good idea to me. (For the record, one of the performance impacts of checking the filename is that bitmaps can't be used to obtain a whitelist of what is to be packed - instead, a regular object walk must be used.)
