On Tue, Nov 7, 2017 at 7:12 AM, Junio C Hamano <gits...@pobox.com> wrote: > Johannes Schindelin <johannes.schinde...@gmx.de> writes: > >> Good. I was wishing for such a feature in the past. >> >> However, the short and sweet `-b` or `-w` switches are really, really >> nice. `--ignore-cr-at-eol` is just very cumbersome to type out. So I think >> you will want to add this patch to your patch series: > > Yeah, I should probably have added that to 2/2 from the beginning. > >> -- snipsnap -- >> diff --git a/contrib/completion/git-completion.bash >> b/contrib/completion/git-completion.bash >> index 0e16f017a41..b7a45e8df29 100644 >> --- a/contrib/completion/git-completion.bash >> +++ b/contrib/completion/git-completion.bash >> @@ -1400,7 +1400,7 @@ __git_diff_common_options="--stat --numstat >> --shortstat --summary >> --patch-with-stat --name-only --name-status --color >> --no-color --color-words --no-renames --check >> --full-index --binary --abbrev --diff-filter= >> - --find-copies-harder >> + --find-copies-harder --ignore-cr-at-eol >> --text --ignore-space-at-eol --ignore-space-change >> --ignore-all-space --ignore-blank-lines --exit-code >> --quiet --ext-diff --no-ext-diff
That series, with this squash, looks good to me.
