Re: [PATCH v2] launch_editor(): indicate that Git waits for user input

[Junio C Hamano]

lars.schnei...@autodesk.com writes:

> Junio posted the original version of this patch [1] as response to my RFC [2].
> I took Junio's patch and slightly changed the commit message as well as the
> message printed to the user after GIT_EDITOR is invoked [3].
>
> Thanks,
> Lars

Thanks.

> diff --git a/editor.c b/editor.c
> index 7519edecdc..23db92d8c6 100644
> --- a/editor.c
> +++ b/editor.c
> @@ -40,6 +40,32 @@ int launch_editor(const char *path, struct strbuf...
> ...
> +             if (close_notice) {
> +                     fprintf(
> +                             stderr,
> +                             "Launched your editor ('%s'). Adjust, save, and 
> close the "
> +                             "file to continue. Waiting for your input... ", 
> editor

How wide is your typical terminal window?  With message this long, a
sample standalone program I used while developing the prototype of
this feature no longer can retract this "temporary" message.

Would something shorter like "Waiting for you to finish editing..."
work well enough?

-- -- --
#include <stdio.h>

int main(void)
{
        const char *EL = "\033[K"; /* Erase in Line */
        const char *editor = "emacsclient";

        fprintf(
                stderr,
                "Launched your editor ('%s'). Adjust, save, and close the "
                "file to continue. Waiting for your input... ", editor);
        fflush(stderr);
        sleep(2);
        fprintf(stderr, "\r%s", EL);
        fflush(stderr);
        return 0;
}
-- -- --