On Fri, Nov 17, 2017 at 12:42:58PM -0500, Todd Zullinger wrote: > > I'd rather add a separate check for msgfmt than mixing the 2 issues, > > because I think that unless it has been explicitly told to do so, Git > > should not try to build git-gui and gitk in the first place if there is > > a big chance that those tools will not work. > > If that's a motivation, wouldn't a check in the gitk and git-gui scripts > handle it? That would provide an error at run time to the user. This > change is about helping the user who builds their own git and then runs it, > so if they built git without wish installed and then ran git-gui, they'd get > a clear error that wish is missing and could easily install it. It's not > needed for the build, so they wouldn't need to rebuild anything.
I think the message is already OK: $ ./gitk ./gitk: 3: exec: wish: not found The question is whether we would want to catch this at build time. And I think Junio's point is that we don't _know_ it's an error at build time. We could be building gitk for use on a system that isn't quite like the build system, so any "solution" here is going to have to make an assumption either way. It's also not foolproof. You could build when wish is present, and then later uninstall it and receive the same error message. I also think all of this is largely orthogonal to gettext. It just so happens that if you don't have gettext installed, we'll try to run wish as part of the build process, but detecting broken tcl setups was definitely not part of the intent there. And the failure actually runs the other way, too. If you have neither gettext nor tcl, you get this confusing output: $ make NO_GETTEXT=1 ... MSGFMT po/pt_pt.msg MSGFMT po/hu.msg Makefile:252: recipe for target 'po/pt_pt.msg' failed make[1]: *** [po/pt_pt.msg] Error 127 (the problem is not msgfmt, but our tcl substitute which cannot run). I'm actually tempted to say that we should not be building the tcl parts by default. IOW, instead of NO_TCLTK we should have USE_TCLTK. That would also require an adjustment by package builders, but it would hopefully be a really obvious one. And once the user has told our Makefile that they definitely want to build the tcl parts, we'd presumably just trust that the tcl path they give us is sane. But it's possible I'm underestimating how many people actually use the tcl scripts. Certainly I don't, and git-gui seems fairly primitive to me these days compared to 3rd party tools. But then I don't use any of them either. ;) -Peff
