On 11/20, Jonathan Nieder wrote: > Previously: [1]. > > This version should be essentially identical to v2. Changes: > - patch 1 is new and should fix the test failure on Windows > - patch 2 is new, discussed at [2] > - patch 5 split off from patch 6 as suggested at [3] > - patch 6 commit message got two new notes to address the worries > from [3] > > Thanks for the helpful reviews, and sorry to take so long to get this > out. Thoughts of all kinds welcome, as always.
Just finished looking through the series. Looks good overall! Thanks again for getting this out! > > Sincerely, > Jonathan Nieder (8): > ssh test: make copy_ssh_wrapper_as clean up after itself > connect: move no_fork fallback to git_tcp_connect > connect: split git:// setup into a separate function > connect: split ssh command line options into separate function > connect: split ssh option computation to its own function > ssh: 'auto' variant to select between 'ssh' and 'simple' > ssh: 'simple' variant does not support -4/-6 > ssh: 'simple' variant does not support --port > > Documentation/config.txt | 24 ++-- > connect.c | 322 > +++++++++++++++++++++++++++++------------------ > t/t5601-clone.sh | 69 ++++++---- > t/t5603-clone-dirname.sh | 2 + > 4 files changed, 265 insertions(+), 152 deletions(-) > > [1] > https://public-inbox.org/git/[email protected]/ > [2] > https://public-inbox.org/git/[email protected]/ > [3] https://public-inbox.org/git/[email protected]/ -- Brandon Williams
