On 24/11/17 13:48, Junio C Hamano wrote: > Phillip Wood <[email protected]> writes: > >> From: Phillip Wood <[email protected]> >> >> Load default values for message cleanup and gpg signing of commits in >> preparation for committing without forking 'git commit'. Note that we >> interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE to >> be consistent with 'git commit' > > Hmph, is that because we never invoke the editor to edit the commit > log message? Over there, scissors is demoted to space when the > editor is not in use, but otherwise this demotion does not occur.
Yes that's right. In fact I'm fairly we always specify an explicit cleanup mode when calling try_to_commit() so the default is there in case that changes in the future. > Just being curious. > >> >> Signed-off-by: Phillip Wood <[email protected]> >> --- >> >> Notes: >> changes since v3: >> - interpret commit.cleanup=scissors to mean COMMIT_MSG_CLEANUP_SPACE >> to match 'git commit'
