On 12/2/2017 12:39 PM, Christian Couder wrote:
On Tue, Nov 21, 2017 at 10:07 PM, Jeff Hostetler <g...@jeffhostetler.com> wrote:
From: Jonathan Tan <jonathanta...@google.com>

  pack_as_from_promisor () {
         HASH=$(git -C repo pack-objects .git/objects/pack/pack) &&
         >repo/.git/objects/pack/pack-$HASH.promisor
+       echo $HASH
  }

Now the exit code of the above function will always be the exit code
of "echo $HASH".
It seems to me that it would be better to add "&&" at the end of the
line above the "echo $HASH".


Fixed. Thanks.
Jeff

Reply via email to