On Wed, Dec 6, 2017 at 5:00 PM, Brandon Williams <bmw...@google.com> wrote: > On 12/05, Eric Sunshine wrote: >> 557a5998d (submodule: remove gitmodules_config, 2017-08-03) touched a >> fair number of built-in commands. It's not clear from the current >> patch's commit message if diff-tree is the only command which >> regressed. Is it? Or are other commands also likely to have regressed? >> Perhaps the commit message could say something about this. For >> instance: "All other commands touched by 557a5998d have been audited >> and were found to be regression-free" or "Other commands may regress >> in the same way, but we will take a wait-and-see attitude and fix them >> as needed because <fill-in-reason>". > > I don't know if any other commands have regressed. This was such an odd > regression that I think it would be difficult to say for certain that > there couldn't be others. I did go through the affected builtins to see > if I could find anything. I came up empty handed so I think we should > be ok.
Thanks for the response. It would be nice to have this explained in the commit message so that future readers don't have to wonder about it.
