On Thu, Dec 7, 2017 at 7:26 AM, Junio C Hamano <[email protected]> wrote: > Jacob Keller <[email protected]> writes: > >> From: Jacob Keller <[email protected]> >> >> Recently, commit f7923a5ece00 ("diff: use skip_to_optional_val()", >> 2017-12-04) changed how we parsed some diff options, preferring >> skip_to_optional_val instead of a more complex skip_prefix() setup. > > I'd expect a moral equivalent of this squashed in when Christian > rerolls the skip-to-optional-val series (with helped-by: attribution > to you, probably). It does not make much sense to leave the initial > breakage like this one in the history. > > Thanks.
Quite correct. I'll be sending a patch with just new tests shortly. Thanks, Jake
