On Sat, Dec 09, 2017 at 01:06:23PM +0100, Kevin Daudt wrote: > On Sat, Dec 09, 2017 at 09:05:30AM +0000, Hans Jerry Illikainen wrote: > > Verify the signature of the tip commit when `pull.verifySignatures` is > > true. This option overrides `merge.verifySignatures` on pull, and can > > be disabled with the option `--no-verify-signatures`. > > Is there a reason why git pull would need a different behaviour from git > merge? Pull itself is just a convenience command for fetch + > merge/rebase. > > One precedent for having a separate configuration option for pull > however is 'pull.ff', so there might be a usecase for it. > > I guess your commit message could use a motivation on why you want to > set this differently from 'merge.verifySignature'.
Thanks for the review! I wasn't sure whether pull.verifySignatures made sense -- I included it to be consistent with pull.ff/merge.ff, but it's scrapped in v2. -- hji
