Junio C Hamano <[email protected]> writes: > Ævar Arnfjörð Bjarmason <[email protected]> writes: > >>> I actually think that the block can go even further down, perhaps >>> close to the run of choices "what variant are we building?" we make >>> at around we have "ifdef NO_CURL". >>> >>> Ævar? >> >> Makes sense to me, do you want to squash this + your proposed edit & >> I'll pick it up if there's another version, or I can re-submit. > > OK. I'll squash in the 'move it further down' to the original > commit that removed DC_SHA1_SUBMODULE and added NO_DC_SHA1_SUBMODULE > when rebuilding 'pu' branch. > > Thanks.
Another minor thing I noticed (which I do not have any squashable fix for) is that "make distclean" does not even work without submodule or this environment, which feels a bit too excessive. I haven't tried to figure out how involved a fix for that would be yet and I do not mind leaving it broken if it would be too much work.
