From: Torsten Bögershausen <tbo...@web.de>
wc -l was used to count the number if lines in test scripts.
$ wc -l Makefile
gives a line like this:
105 Makefile
while Mac OS has 4 leading spaces:
105 Makefile
And this means that shell expressions like
test "$(wc -l <expect)" = "4" don't work under Mac OS,
Commit fb3340a6 introduced test_line_count() as a portable solution.
Add a check in check-non-portable-shell.pl to find '"' between
`wc -l` and '=' and hint the user about test_line_count().
Reviewed-by: Johannes Schindelin <johannes.schinde...@gmx.de>
Signed-off-by: Torsten Bögershausen <tbo...@web.de>
---
t/check-non-portable-shell.pl | 1 +
1 file changed, 1 insertion(+)
diff --git a/t/check-non-portable-shell.pl b/t/check-non-portable-shell.pl
index 03dc9d285..e07f02843 100755
Use () around the hint.
Thanks to Eric for the sharp eyes.
--- a/t/check-non-portable-shell.pl
+++ b/t/check-non-portable-shell.pl
@@ -21,6 +21,7 @@ while (<>) {
/^\s*declare\s+/ and err 'arrays/declare not portable';
/^\s*[^#]\s*which\s/ and err 'which is not portable (please use type)';
/\btest\s+[^=]*==/ and err '"test a == b" is not portable (please use
=)';
+ /\bwc -l.*"\s*=/ and err '`"$(wc -l)"` is not portable (please use
test_line_count)';
/\bexport\s+[A-Za-z0-9_]*=/ and err '"export FOO=bar" is not portable
(please use FOO=bar && export FOO)';
# this resets our $. for each file
close ARGV if eof;
--
2.15.1.271.g1a4e40aa5d
