"phillip.w...@talktalk.net" <phillip.w...@talktalk.net> writes:
>>----Original Message---- >>From: johannes.schinde...@gmx.de >>Date: 22/12/2017 11:50 >>To: <git@vger.kernel.org> >>Cc: "Junio C Hamano"<gits...@pobox.com>, "Phillip Wood"<phillip. > w...@dunelm.org.uk>, "Kaartic Sivaraam"<kaartic.sivar...@gmail.com> >>Subj: [PATCH] sequencer: assign only free()able strings to gpg_sign >> >>The gpg_sign member of the replay_opts structure is of type `char *`, >>meaning that the sequencer deems the string to which gpg_sign points > to >>be under its custody, i.e. it needs to be free()d by the sequencer. >> >>Therefore, let's only assign malloc()ed buffers to it. >> >>Reported-by: Kaartic Sivaraam <kaartic.sivar...@gmail.com> >>Signed-off-by: Johannes Schindelin <johannes.schinde...@gmx.de> >>--- >> >> Phillip, if you want to squash these changes into your patches, >> I'd totally fine with that. >> > > Hi Johannes, thanks for putting this together, the patch it fixes is > already in next so I think it'd be best to leave this one separate. I > wonder if it would be worth adding another test, see below. Thanks, both. Let's queue this on top as a fix-up.
