On Thu, Jan 11, 2018 at 04:39:04PM -0500, Randall S. Becker wrote: > > executed because the test_commit fails with a non-zero git commit > > completion code. There is no rn---- (actual r n 252 252 252 252) in > > the objects directory - even the 'rn' does not correspond to > > anything.. I am suspecting an unterminated string that ran into > > freed memory somewhere, but that's speculative. > > Does anyone recall fixing this one at or near > dfe46c5ce6e68d682f80f9874f0eb107e9fee797? There was a rewrite of > sha1_file.c including link_alt_odb_entry where I am finding memory > corruptions. I think I'm chasing something that was already fixed some > time after 2.13.5 but the common parent to where I am is pretty far > back compared to master.
I did a lot of work on link_alt_odb_entry() in the past year or so, and I seem to recall seeing some cases where we could run into unterminated memory in the error message. Maybe dc732bd5cb (read_info_alternates: read contents into strbuf, 2017-09-19)? -Peff
