On Tue, Jan 23, 2018 at 01:10:43AM +0100, Ævar Arnfjörð Bjarmason wrote:
> > On Mon, Jan 22 2018, Jeff King jotted: > > > On Mon, Jan 22, 2018 at 07:31:54PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> + opts.diffopt.stat_width = 70; > >> > >> diff_setup_done(&opts); > > > > I wondered how this should interact with any config, but I don't think > > you can actually configure the stat-width. You _can_ configure > > diff.statgraphwidth, though, which seems like a funny inconsistency. > > Isn't the numeric argument to --stat (this works with/without this > patch): > > $ git format-patch -10 --stdout --stat=30 -- t|grep -m 5 ' | ' > ...submodule-update.sh | 1 + > ...ule-update.sh | 14 ++++++ > ...-addresses.sh | 27 --- > t/t9000/test.pl | 67 ------ > ...send-email.sh | 19 ++++++ > $ git format-patch -10 --stdout --stat=90 -- t|grep -m 5 ' | ' > t/lib-submodule-update.sh | 1 + > t/lib-submodule-update.sh | 14 ++++++++++++++ > t/t9000-addresses.sh | 27 ------------------------- > t/t9000/test.pl | 67 > -------------------------------------------------------------- > t/t9001-send-email.sh | 19 +++++++++++++++++++ Yeah, I meant by actual on-disk config. I didn't actually look at the patch closely, but I assumed that "format-patch --stat=90" would still override this (if not, then I think that would be a bug). -Peff
