The test helper is used as "svnrdump" during the
execution of this test, but the arrangement had a few undesirable

 - it relied on symbolic links;
 - unportable "export VAR=VAL" was used;
 - GIT_BUILD_DIR variable was not quoted correctly;
 - it assumed that the Python interpreter is in /usr/bin/ and
   called "python" (i.e. not "python2.7" etc.)

Rework this by writing a small shell script that spawns the right
Python interpreter, using the right quoting.

Signed-off-by: Junio C Hamano <>

 * The analysis above counts more bugs than the number of lines that
   are deleted in this section of the code...

 t/ | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/t/ b/t/
index 4f2dfe0..d7be66a 100755
--- a/t/
+++ b/t/
@@ -12,9 +12,13 @@ then
-# We override svnrdump by placing a symlink to the svnrdump-emulator in .
-export PATH="$HOME:$PATH"
-ln -sf $GIT_BUILD_DIR/contrib/svn-fe/ "$HOME/svnrdump"
+# Override svnrdump with our simulator
+write_script "$HOME/svnrdump" <<\EOF
+exec "$PYTHON_PATH" "$GIT_BUILD_DIR/contrib/svn-fe/" "$@"
 init_git () {
        rm -fr .git &&

To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to
More majordomo info at

Reply via email to