On Fri, Feb 2, 2018 at 2:15 AM, Nicolas Morey-Chaisemartin
<nmoreychaisemar...@suse.com> wrote:
> Le 02/02/2018 à 02:29, Eric Sunshine a écrit :
>> On Thu, Feb 1, 2018 at 12:21 PM, Nicolas Morey-Chaisemartin
>> <nmoreychaisemar...@suse.com> wrote:
>>> - I'll post another series to fix the misleading messages in both commit.c 
>>> and tag.c when launch_editor fails
>> Typically, it's easier on Junio, from a patch management standpoint,
>> if you submit all these related patches as a single series.
>> Alternately, if you do want to submit those changes separately, before
>> the current patch lands in "master", be sure to mention atop which
>> patch (this one) the additional patch(es) should live. Thanks.
> Well this patch does not touch any of the line concerned by fixing the error 
> message. So both should be able to land in any order.

Yup, that's a reasonable way to look at it. I see them as related
(thus a potential patch series) simply because the existing error
message in tag.c is fine, as is, until the --edit option is
introduced, after which it becomes a bit iffy. Not a big deal, though.

> Plus I've never had to look into localization yet so I'm going to screw up on 
> the first few submissions (not counting on people that disagree or would 
> prefer another message),

As long as you just change the content of double-quoted string, you
shouldn't have to worry about localization. The localization folks
will handle the .po files and whatnot.

Reply via email to