On Wed, Dec 19, 2012 at 07:51:16PM -0800, Junio C Hamano wrote:

> > ++          if (limit_pathspec_to_literal())
> > ++                  item->nowildcard_len = item->len;
> > ++          else {
> > ++                  item->nowildcard_len = simple_length(path);
> > ++                  if (item->nowildcard_len < item->len) {
> > ++                          pathspec->has_wildcard = 1;
> > ++                          if (path[item->nowildcard_len] == '*' &&
> > ++                              no_wildcard(path + item->nowildcard_len + 
> > 1))
> > ++                                  item->flags |= PATHSPEC_ONESTAR;
> > ++                  }
> >  +          }
> 
> Hmph.  I thought that returning the length without any "stop at glob
> special" trick from simple_length() would be a simpler resolution.
> 
> That is what is queued at the tip of 'pu', anyway.

I don't think we can make a change in simple_length. It gets used not
only for pathspecs, but also for parsing exclude patterns, which I do
not think should be affected by this option.

-Peff
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Reply via email to