Jeff King <p...@peff.net> writes:
> On Tue, Dec 18, 2012 at 12:31:43PM -0800, Junio C Hamano wrote:
>> * jk/error-const-return (2012-12-15) 2 commits
>> - silence some -Wuninitialized false positives
>> - make error()'s constant return value more visible
>> Help compilers' flow analysis by making it more explicit that
>> error() always returns -1, to reduce false "variable used
>> uninitialized" warnings.
>> This is still an RFC.
> What's your opinion on this?
Ugly but not too much so, and it would be useful.
The only thing that makes it ugly is that it promises error() will
return -1 and nothing else forever, but at this point in the
evolution of the codebase, I think we are pretty much committed to
it anyway, so I do not think it is a problem.
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html