On 02/05 01:50, Stefan Beller wrote:
> On Sat, Feb 3, 2018 at 6:03 PM, Chen Jingpiao <chenjingp...@gmail.com> wrote:
> > Add the commit.signOff configuration variable to use the -s or --signoff
> > option of git commit by default.
> >
> > Signed-off-by: Chen Jingpiao <chenjingp...@gmail.com>
> > ---
>
> Welcome to the Git community!
>
> >
> > Though we can configure signoff using format.signOff variable. Someone like
> > to
> > add Signed-off-by line by the committer.
>
> There is more discussion about this at
> https://public-inbox.org/git/1482946838-28779-1-git-send-email-ehabk...@redhat.com/
> specifically
> https://public-inbox.org/git/xmqqtw9m5s5m....@gitster.mtv.corp.google.com/
>
> Not sure if there was any other reasons and discussions brought up
> since then, but that discussion seems to not favor patches that
> add .signoff options.
Thank you.
I agree with Johannes Schindelin once said "a signoff _has_ to be a conscious
act, or else it will lose its meaning."
I think I shouldn't add this configuration variable.
When add configuration variable for sign-off to format-patch have some
discussion:
https://public-inbox.org/git/20090331204338.ga88...@macbook.lan/
https://public-inbox.org/git/20090401102610.gc26...@coredump.intra.peff.net/
https://public-inbox.org/git/7veiw69p26....@gitster.siamese.dyndns.org/
--
Chen Jingpiao
