On 02/12, Stefan Beller wrote: > This is a real take on the first part of the recent RFC[1]. > > Jonathan Tan suggested[2] that "sha1_loose_object_info to handle arbitrary > repositories" > might be a good breaking point for a first part at that RFC at patch 38. > This series is smaller and contains only 26 patches as the patches in the big > RFC were slightly out of order. > > I developed this series partly by writing patches, but mostly by cherrypicking > from that RFC on top of current master. I noticed no external conflicts apart > from one addition to the repositories _INIT macro, which was easy to resolve. > > Comments in the early range of that RFC were on 003 where Junio pointed out > that the coccinelle patch ought to be not in contrib/coccinelle, so I put it > in a sub directory there, as 'make coccicheck' doesn't traverse subdirs. > > brian had a questoin on patch 25 in the RFC, but that seemed to resolve itself > without any suggestion to include into this series[3]. > > Duy suggested that we shall not use the repository blindly, but should > carefully > examine whether to pass on an object store or the refstore or such[4], which > I agree with if it makes sense. This series unfortunately has an issue with > that > as I would not want to pass down the `ignore_env` flag separately from the > object > store, so I made all functions that only take the object store to have the raw > object store as the first parameter, and others using the full repository. > > Eric Sunshine brought up memory leaks with the RFC, and I would think to > have plugged all holes.
I've looked through the patches and I think they look good. At the end of the series all the #define tricks have been eliminated so we don't have to worry about them possibly being left and forgotten :) Thanks for getting the ball rolling on this. > > [1] https://public-inbox.org/git/20180205235508.216277-1-sbel...@google.com/ > [2] > https://public-inbox.org/git/20180207143300.ce1c39ca07f6a0d64fe0e...@google.com/ > [3] > https://public-inbox.org/git/20180206011940.gd7...@genre.crustytoothpaste.net/ > [4] > https://public-inbox.org/git/cacsjy8cggekpx4czkyytsprj87uqvkzsol7fyt__p2dh_1l...@mail.gmail.com/ > > Thanks, > Stefan > > Jonathan Nieder (8): > pack: move prepare_packed_git_run_once to object store > pack: move approximate object count to object store > sha1_file: add repository argument to sha1_file_name > sha1_file: add repository argument to map_sha1_file > sha1_file: allow stat_sha1_file to handle arbitrary repositories > sha1_file: allow open_sha1_file to handle arbitrary repositories > sha1_file: allow map_sha1_file_1 to handle arbitrary repositories > sha1_file: allow sha1_loose_object_info to handle arbitrary > repositories > > Stefan Beller (18): > repository: introduce raw object store field > object-store: move alt_odb_list and alt_odb_tail to object store > object-store: free alt_odb_list > object-store: move packed_git and packed_git_mru to object store > object-store: close all packs upon clearing the object store > sha1_file: add raw_object_store argument to alt_odb_usable > sha1_file: add repository argument to link_alt_odb_entry > sha1_file: add repository argument to read_info_alternates > sha1_file: add repository argument to link_alt_odb_entries > sha1_file: add repository argument to prepare_alt_odb > sha1_file: allow link_alt_odb_entries to handle arbitrary repositories > sha1_file: allow prepare_alt_odb to handle arbitrary repositories > sha1_file: add repository argument to stat_sha1_file > sha1_file: add repository argument to open_sha1_file > sha1_file: add repository argument to map_sha1_file_1 > sha1_file: add repository argument to sha1_loose_object_info > sha1_file: allow sha1_file_name to handle arbitrary repositories > sha1_file: allow map_sha1_file to handle arbitrary repositories > > builtin/am.c | 2 +- > builtin/clone.c | 2 +- > builtin/count-objects.c | 6 +- > builtin/fetch.c | 2 +- > builtin/fsck.c | 13 ++- > builtin/gc.c | 4 +- > builtin/grep.c | 2 +- > builtin/index-pack.c | 1 + > builtin/merge.c | 2 +- > builtin/pack-objects.c | 21 ++-- > builtin/pack-redundant.c | 6 +- > builtin/receive-pack.c | 3 +- > cache.h | 46 ++------ > contrib/coccinelle/refactoring/packed_git.cocci | 7 ++ > environment.c | 5 +- > fast-import.c | 6 +- > http-backend.c | 6 +- > http-push.c | 1 + > http-walker.c | 4 +- > http.c | 6 +- > mru.h | 1 + > object-store.h | 75 +++++++++++++ > object.c | 26 +++++ > pack-bitmap.c | 4 +- > pack-check.c | 1 + > pack-revindex.c | 1 + > packfile.c | 64 +++++------ > packfile.h | 2 +- > path.c | 2 +- > reachable.c | 1 + > repository.c | 17 ++- > repository.h | 7 +- > server-info.c | 6 +- > sha1_file.c | 135 > +++++++++++++----------- > sha1_name.c | 11 +- > streaming.c | 5 +- > 36 files changed, 321 insertions(+), 182 deletions(-) > create mode 100644 contrib/coccinelle/refactoring/packed_git.cocci > create mode 100644 object-store.h > > -- > 2.16.1.73.ga2c3e9663f.dirty > -- Brandon Williams
