On Tue, Feb 13, 2018 at 11:23 PM, Eric Sunshine <sunsh...@sunshineco.com> wrote: > On Mon, Feb 12, 2018 at 10:55 PM, Eric Sunshine <sunsh...@sunshineco.com> > wrote: >> On Mon, Feb 12, 2018 at 8:41 PM, Stefan Beller <sbel...@google.com> wrote: >>> + * Output the formatted string in the specified color (and then reset to >>> normal >>> + * color so subsequent output is uncolored). Omits the color encapsulation >>> if >>> + * `color` is NULL. The `color_fprintf_ln` prints a new line after >>> resetting >>> + * the color. BUG: The `color_print_strbuf` prints the given pre-formatted >>> + * strbuf instead, up to its first NUL character. >> >> "`color_print_strbuf` prints the given pre-formatted strbuf (BUG: but >> only up to the first NUL character)." >> >> Probably not worth a re-roll is Junio can amend it locally. > > By the way, thanks for the patience in the face of the nit-picking > this patch has undergone.
In retrospect it is clear why we have so much nitpicking here as it adds documentation to a part of git that is rather non-essential. ;-) Thanks for bearing with my inability to write perfect code on the first try.