Dan Jacques <[email protected]> writes: > +# RUNTIME_PREFIX's resolution logic requires resource paths to be expressed > +# relative to each other and share an installation path. > +# > +# This is a dependnecy in:
dependency? > +# - Git's binary RUNTIME_PREFIX logic in (see "exec_cmd.c"). > +# - The runtime prefix Perl header (see > +# "perl/header_templates/runtime_prefix.template.pl"). > +ifdef RUNTIME_PREFIX > + > +ifneq ($(filter /%,$(firstword $(gitexecdir_relative))),) > +$(error RUNTIME_PREFIX requires a relative gitexecdir, not: $(gitexecdir)) > +endif I see Dscho is CC'ed so I won't worry about "is there a more portable test than 'the path begins with a slash' to see if a path is relative, or is this good enough even for Windows in the context of this patch?". It won't be a show-stopper issue as long as we do not error out with false positive, though ;-).
