On Sun, Mar 25, 2018 at 5:15 PM Ævar Arnfjörð Bjarmason <[email protected]>
wrote:
> This looks good to me this time around, couple of small nits (maybe
> Junio can amend while queuing):
> * You add a dependnecy typo in 2/3 but fix it again in 3/3. Should be
> squashed.
d'oh, I'll fix that in my local copy so that if I do end up needing to
upload a new version, it's available.
> * s/\Q${gitexecdir_relative}\E$// in 2/3 can be done less verbosely as
> s/\Q$gitexecdir_relative\E$//. Discussed before in
https://public-inbox.org/git/cad1ruu-3q_syvjoru+vey2-0cpmz1el-41z6el7sq4usij0...@mail.gmail.com/
> seems like something you just forgot about.
Oh sorry, I must have missed that. I have a personal preference for adding
brackets for clarity; it leaked into this patch set. I did implement most
of the suggestion, which was to use the escaped Q/E instead of equals.
Stylistically I still prefer the braces, but I'll defer to you and remove
them in my pending patch set in case I'm asked to submit another version.
Cheers!
-Dan
