On Fri, Apr 6, 2018 at 2:39 AM, Taylor Blau <m...@ttaylorr.com> wrote: > [...] > In this patch, we support `--type=<int|bool|bool-or-int|...>` in > addition to `--int`, `--bool`, and etc. This allows the aforementioned > upcoming patch to support querying a color value with a default via > `--type=color --default=...`, without squandering `--color`. > > Signed-off-by: Taylor Blau <m...@ttaylorr.com> > --- > diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt > @@ -38,12 +38,12 @@ existing values that match the regexp are updated or > unset. If > +The `--type` option requests 'git config' to ensure that the configured > values > +associated with the given variable(s) are of the given type. When given > +`--type`, 'git config' will ensure that the variable(s) are of the given type > +and convert the value to the canonical form. If no type specifier is passed, > no > +checks or transformations are performed on the value. Callers may unset any > +pre-existing type specifiers with `--no-type`.
Sorry for being such a stickler, but this is still too mushy. The first two sentences are saying effectively the same thing. One or the other should be dropped or they should somehow be combined in a way that says everything that needs to be said without repetition. If necessary, iterate over updates of this paragraph here in the email thread until a polished version is reached rather than re-rolling the entire series every few minutes.