On Sat, Mar 31, 2018 at 12:02:56PM +0200, Nguyễn Thái Ngọc Duy wrote:

> v8 changes
> - prefer BUG() over die()
> - do "1U <<" instead of "1 << " to avoid undefined behavior with
>   signed shifting.
> - add more comments based on Jeff's feedback
> - plug a leak in try_delta() when delta_size is too large
> - be kind and set depth/cache_max_small_delta_size to max limit
>   instead of dying when the user gives a value over limit
> - make travis execute pack-objects uncommon code
> - use git_env_*() instead of manually handling getenv() values
> - fallback code for when a new pack is added when pack-objects is
>   running
> - Compressed cached delta size limit is increased from 64k to 1MB
> - Cached delta size limit is decreased from 2G to 1MB

I ran out of time to give this a very careful review, and I'm trying to
clear my plate before going offline for a few weeks. I did look at the
interdiff and it seemed sane.

So I think going forward, you can at least consider my objections
retracted. I don't promise this iteration is bug-free, but I think
you've addressed all my earlier issues. :)



Reply via email to