2018-04-19 2:53 GMT+03:00 Stefan Beller <[email protected]>: > Hi Eddy, > > all the following patches 3-9 are touching the test as added in patch > 2, which would go best with this patch. > Could you squash all commits into one?
Yes, I did not have time yesterday to put all changes into a single commit with an associated note (because note managment seems to be a huge pain), so I preferred small commits. But I wanted to get your feedback on something, I'll reply in thread arm where you actually suspected the problem. > There are a couple ways to do it: > > git reset --soft > git commit -a --reuse-commit-message=<...> > > or using > > git rebase --interactive origin/master > # and then marking all but the first as "fixup" I am aware of git rebase -i and use it regularly, that's why patches 3-9 have the 'fixup' prefix. > I think the end result looks good, but that is best reviewed as one > piece instead of 9 patches. -- Eddy Petrișor
